Open
Conversation
Contributor
Author
|
CC: @kevinjqliu @geruh |
geruh
reviewed
Feb 9, 2026
geruh
reviewed
Feb 9, 2026
| path: .coverage* | ||
| include-hidden-files: true | ||
|
|
||
| benchmark-test: |
Contributor
There was a problem hiding this comment.
Could we run the benchmarks against main as a baseline in the same job? It would be cool to create a report of all the benchmarks that can be uploaded onto the PR. Maybe we should think of this a bit more.
Contributor
Author
There was a problem hiding this comment.
Let me try something and add it in a follow up commit
geruh
reviewed
Feb 9, 2026
| - name: Install system dependencies | ||
| run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos | ||
| - name: Install | ||
| run: make install |
Contributor
There was a problem hiding this comment.
test_partitioned_write currently prints average runtime but has no threshold or assertion. Worth adding a baseline comparison
geruh
reviewed
Feb 9, 2026
| run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos | ||
| - name: Install | ||
| run: make install | ||
| - name: Run benchmarks |
Contributor
There was a problem hiding this comment.
Looks like these files are never got produced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Rationale for this change
We have benchmark tests defined here
This PR adds them to the CI as a job to run
Are these changes tested?
Locally executed the make command
Are there any user-facing changes?
No